Add Support for Loading Environment Variables from .env Files #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleone87
reviewed
Feb 8, 2024
|
@JamborJan please fix linting issues |
|
Hi @mleone87, I guess you asked me to fix the staticcheck error. I did that. Fixing the linting would involve a ton of work as the whole project is not properly setup. I can do that. But I would prefer to do this in a separate issue / pull request to not have scope creep in this specific PR. Are you okay with that? Thank you. |
|
@JamborJan it's ok I was just referring to the lint error on this commit, other are warnings! |
|
Thank you @mleone87 . Anyway if we want to get rid of the warnings I can do that. Sort of a probation to get my credits for becoming a proper contributor 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Telmate/proxmox-api-gomaintainers,I am just starting to contribute to the Proxmox ecosystem. I want to see a nice and useful terraform provider and do my part to it. As I learned now the
Telmate/proxmox-api-gois the first crucial thing and I cloned the repo to play around with it to get started.My Motivation:
When it came to exporting environment variables to setup the configuration, I thought
.envfiles would be a nice thing to have. I usually have multiple small projects ongoing at the same time and always having to typeexport KEY=valueis error prone and as it is part of the bash history also insecure.Implementation:
To address this, I have integrated the
godotenvpackage, which allows the application to automatically load environment variables from a.envfile at runtime. This means users can now store their sensitive credentials safely in.envfiles, significantly reducing the risk of accidental exposure, mixing up things etc. I also added.envto the gitignore file, everybody should know that this is a sensitive file which must not be shared.Changes Made:
godotenvas a dependency ingo.mod..envfile loading logic in the main initialization section of the application..envfiles with the Proxmox API Go client.Thank you for considering my PR.